Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Split-off render sprite atlas #8937

Merged
merged 2 commits into from
May 12, 2017
Merged

Split-off render sprite atlas #8937

merged 2 commits into from
May 12, 2017

Conversation

ivovandongen
Copy link
Contributor

@ivovandongen ivovandongen commented May 9, 2017

Splits the render side of sprite atlas for use on another thread.

See #8820

@ivovandongen ivovandongen added the Core The cross-platform C++ core, aka mbgl label May 9, 2017
@ivovandongen ivovandongen self-assigned this May 9, 2017
@ivovandongen ivovandongen mentioned this pull request May 10, 2017
28 tasks
@ivovandongen
Copy link
Contributor Author

@jfirebaugh I've added an Impl to style::Image according to #8820 (comment). I kept the SpriteAtlas intact instead of adding the image collection directly on Style like you've suggested in #8820 (comment). Thought that might be a bit more nicely encapsulated, but I can change that if you prefer.

@jfirebaugh
Copy link
Contributor

Yes, I think it's better to add the image collection directly on Style. The main reason is that we want to make style images more like sources and layers -- a collection of items held by the style, which you can add to and remove from. Separately, "atlas" is a rendering-specific concept: a single texture which can be indexed into by vertex attributes in order to render individual images.

@jfirebaugh jfirebaugh merged commit cc9f040 into master May 12, 2017
@jfirebaugh jfirebaugh deleted the render-sprite-atlas branch May 12, 2017 20:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Core The cross-platform C++ core, aka mbgl
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants